[libcxx-commits] [PATCH] D132092: [2a/3][ASan][libcxx] std::deque annotations

Wed Jul 5 07:52:13 PDT 2023

AdvenamTacet added inline comments.

================
Comment at: libcxx/include/__config:910
     __sanitizer_annotate_contiguous_container(const void*, const void*, const void*, const void*);
+#    if _LIBCPP_CLANG_VER >= 1600
+extern "C" _LIBCPP_EXPORTED_FROM_ABI void __sanitizer_annotate_double_ended_contiguous_container(
----------------
ldionne wrote:
> This breaks on AppleClang when using asan, because then `_LIBCPP_CLANG_VER` isn't defined and we check for `_LIBCPP_CLANG_VER >= 1600`. That triggers `-Wundef`, which is turned into an error in our test suite.
Hey! What is the correct way of checking the version then?

Also, can I fix it in another commit, or should we revert the whole commit, fix it and land it again?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132092/new/

https://reviews.llvm.org/D132092