[libcxx-commits] [PATCH] D132092: [2a/3][ASan][libcxx] std::deque annotations

Wed Jul 5 07:24:16 PDT 2023

ldionne added inline comments.
Herald added a subscriber: wangpc.

================
Comment at: libcxx/include/__config:910
     __sanitizer_annotate_contiguous_container(const void*, const void*, const void*, const void*);
+#    if _LIBCPP_CLANG_VER >= 1600
+extern "C" _LIBCPP_EXPORTED_FROM_ABI void __sanitizer_annotate_double_ended_contiguous_container(
----------------
This breaks on AppleClang when using asan, because then `_LIBCPP_CLANG_VER` isn't defined and we check for `_LIBCPP_CLANG_VER >= 1600`. That triggers `-Wundef`, which is turned into an error in our test suite.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132092/new/

https://reviews.llvm.org/D132092