[libcxx-commits] [PATCH] D154489: [libc++][tests] Fix a test exercising incorrect overload

Wed Jul 5 05:45:31 PDT 2023

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

In D154489#4473185 <https://reviews.llvm.org/D154489#4473185>, @pfusik wrote:

> I noticed a test I added in https://reviews.llvm.org/D153709 wasn't testing the constructor overload it was supposed to test. Instead, it tested the same overload as `string-alloc.mode.pass.cpp`.

I don't think that's true. The test was exercising this constructor: `explicit basic_stringbuf(basic_string<charT, traits, Allocator>&& s, ios_base::openmode which = ios_base::in | ios_base::out)` unless I missed something subtle. We're specifying a test allocator in the type of `basic_stringbuf`, but we're not passing any allocator to the constructor itself. Did I miss something?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154489/new/

https://reviews.llvm.org/D154489