[libcxx-commits] [PATCH] D154425: [libc++] add basic runtime assertions to <latch>

Edo via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jul 4 23:28:05 PDT 2023


diamante0018 updated this revision to Diff 537227.
diamante0018 added a comment.

Added ctor unit test.
Correct assertion placement.
Remove one assertion as I realized that immediately after we are calling a function with the same kind of assertion. So perhaps it's not worth it to call .load() to check for the internal counter when we have a similar test right after that is checked without calling any extra operations


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154425/new/

https://reviews.llvm.org/D154425

Files:
  libcxx/include/latch
  libcxx/test/libcxx/thread/thread.latch/assert.arrive_and_wait.pass.cpp
  libcxx/test/libcxx/thread/thread.latch/assert.count_down.pass.cpp
  libcxx/test/libcxx/thread/thread.latch/assert.ctor.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D154425.537227.patch
Type: text/x-patch
Size: 5790 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230705/470a44db/attachment.bin>


More information about the libcxx-commits mailing list