[libcxx-commits] [PATCH] D153210: Revert "[libc++][Modules] Add missing includes and exports"

[Ian Anderson via Phabricator via libcxx-commits]

iana abandoned this revision.
iana added a comment.

In D153210#4472096 <https://reviews.llvm.org/D153210#4472096>, @ldionne wrote:

> This is removing a bunch of includes that are used by the files in which they appear(ed). I don't understand why we'd want to do this. Can you explain?

This was a fix I originally did for some errors that I was seeing in D144322 <https://reviews.llvm.org/D144322>. It turned out that once I fixed these compile errors, I just got link errors. Those needed module exports to fix, and it was easier to go back to the original state to figure out which of the transitive includes, that are visible in a mega-module setup, are the load bearing ones for the linker. But I agree that in the end it it's more correct to have all of these includes so I'll drop this review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153210/new/

https://reviews.llvm.org/D153210