[libcxx-commits] [PATCH] D153336: [libc++] Fixes thread::id's operator<<.

[Jakub Mazurkiewicz via Phabricator via libcxx-commits]

JMazurkiewicz added inline comments.


================
Comment at: libcxx/include/__thread/thread.h:184
+
+    __os.flags(__default | ((__flags & ios_base::left) ? ios_base::left : ios_base::right));
+    __os << __id.__id_;
----------------
Should we should use C locale while printing? Values from `std::numpunct` (`thousands_sep` and `grouping`) may affect text representation when type of `__id.__id_` is integral.

I've mentioned it in this issue too: https://github.com/llvm/llvm-project/issues/62073.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153336/new/

https://reviews.llvm.org/D153336