[libcxx-commits] [PATCH] D154425: [libc++] add basic runtime assertions to <latch>

[Edo via Phabricator via libcxx-commits]

diamante0018 updated this revision to Diff 537166.
diamante0018 edited the summary of this revision.
diamante0018 added a comment.

I addressed the review.

Please note the following:
Because in the llvm's implementation max() returns the max value of ptrdiff_t" (numeric_limits<ptrdiff_t>::max();) It should not be possible to check for that in an assertion.

Note that I used memory_order_relaxed in the assertions as that seems to be the memory order that has the potential to cause less collateral damage. Let me know if it's fine please.

Thanks


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154425/new/

https://reviews.llvm.org/D154425

Files:
  libcxx/include/latch
  libcxx/test/libcxx/thread/thread.latch/assert.arrive_and_wait.pass.cpp
  libcxx/test/libcxx/thread/thread.latch/assert.count_down.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D154425.537166.patch
Type: text/x-patch
Size: 4605 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230704/3d446514/attachment.bin>