[libcxx-commits] [PATCH] D153209: Revert "[libc++][PSTL] Add missing includes to PSTL headers"

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.
Herald added a subscriber: wangpc.

> I guess it doesn't hurt to have these extra includes, but they mask the missing module exports which are important to have. Without the exports, many unit tests have compiler errors, and even linker errors.

We follow include-what-you-use in libc++ -- that's the baseline rule. This patch moves us away from include-what-you-use, so I don't think we want to move forward with it. The stuff we export from the modulemap is not what we consider the baseline -- we tweak it however it needs to be tweaked to fix stuff (a rather poor strategy TBH).

If it's not needed for your stack of patches (I think it's not), then I would drop this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153209/new/

https://reviews.llvm.org/D153209