[libcxx-commits] [PATCH] D153213: [libc++][Modules] Add missing submodules

Ian Anderson via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jul 3 22:02:02 PDT 2023


iana added inline comments.


================
Comment at: libcxx/utils/libcxx/test/header_information.py:73-86
+private_textual_headers = frozenset((
+    # Not standalone headers, alternate implementations for __algorithm/pstl_backends/cpu_backends/backend.h
+    "__algorithm/pstl_backends/cpu_backends/serial.h",
+    "__algorithm/pstl_backends/cpu_backends/thread.h",
+
+    "__config",
+    "experimental/__config",
----------------
ldionne wrote:
> What happens if you just drop this diff entirely? Does `libcxx/test/libcxx/private_headers.gen.py` start failing (and how)?
Let me see, it was originally failing with __iterator/readable_traits.h on an earlier version of the stack and I just added these later.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153213/new/

https://reviews.llvm.org/D153213



More information about the libcxx-commits mailing list