[libcxx-commits] [PATCH] D154246: [libc++] Add check for building with picolibc

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

Thanks for working on this! I would love to have a CI configuration with an embedded libc.



================
Comment at: libcxx/utils/ci/run-buildbot:617
+    # -Wno-atomic-alignment to disable warning-as-error:
+    # cxx_atomic_impl.h:376:12: large atomic operation may incur significant performance
+    # penalty; the access size (4 bytes) exceeds the max lock-free size (0  bytes)
----------------
I think we should just use a pragma to disable the warning in that function.


================
Comment at: libcxx/utils/ci/run-buildbot:625
+    echo "--- Installing libc++, libc++abi and libunwind to a fake location"
+    ${NINJA} -vC "${BUILD_DIR}" install-cxx install-cxxabi install-unwind
+;;
----------------
We're not running the tests? I would expect

```
echo "+++ Running the libc++ tests"
${NINJA} -vC "${BUILD_DIR}" check-cxx check-cxxabi check-unwind
```


================
Comment at: libcxx/utils/ci/run-buildbot:654
     echo "+++ Running the libc++ tests"
     ${NINJA} -vC "${BUILD_DIR}" check-cxx
 ;;
----------------
Should we add something to `libcxx/docs/index.rst` in the platform support table that mentions that picolibc is supported?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154246/new/

https://reviews.llvm.org/D154246