[libcxx-commits] [PATCH] D153832: [libc++][Modules] std.functional.__functional.invoke and std.type_traits.underlying_type can't export std.type_traits

Mon Jul 3 11:58:44 PDT 2023

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM without the script.

I spoke at length with @iana about this patch, in particular about the fact that these exports are pretty arbitrary. They are, but so are some of the exports we already have in the modulemap anyway. Let's move forward with this because I get the feeling that the only way to make progress here is to get to D144322 <https://reviews.llvm.org/D144322> ASAP and then clean up the mess in our modulemap once we can actually see failures in the CI.

================
Comment at: libcxx/utils/find_transitive_includes.py:1
+#===----------------------------------------------------------------------===##
+#
----------------
Let's not check in this script since it was only (?) useful as a tool for you to come up with this patch. We don't expect to ever have to do this again, right?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153832/new/

https://reviews.llvm.org/D153832