[libcxx-commits] [PATCH] D152382: [libc++] Expand the contents of LIBCXX_ENABLE_FILESYSTEM

Mon Jul 3 08:18:49 PDT 2023

barannikov88 added a comment.

In D152382#4468473 <https://reviews.llvm.org/D152382#4468473>, @ldionne wrote:

> The fix here would probably be to split `TimeSpec` out of `posix_compat.h` so that it can be included from `filesystem_clock.cpp` without pulling in all of `posix_compat.h`. Or we could also conditionalize the definition of some things inside `posix_compat.h` based on `_LIBCPP_HAS_NO_FILESYSTEM`.
>
> TBH, it's kind of hard for me to formulate a patch without seeing exactly what the issue is and being able to reproduce, given that those are not part of our CI configurations. I think it would be a lot easier if one of the affected folks came up with that patch -- I'll be happy to review it, it's just that I'll be shooting blind if I try to fix this issue for you folks without being able to see it first hand.

If that helps, our setup is baremetal newlib (custom target). Newlib provides some sys headers, but apparently not this one https://cygwin.com/git/?p=newlib-cygwin.git;a=tree;f=newlib/libc/include/sys.
I guess it would be the same with picolibc https://github.com/picolibc/picolibc/tree/main/newlib/libc/include/sys.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152382/new/

https://reviews.llvm.org/D152382