[libcxx-commits] [PATCH] D153920: [clang] Move the clang formatting job to run-buildbot to fix the CI

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jul 3 06:29:24 PDT 2023


ldionne added inline comments.


================
Comment at: libcxx/utils/ci/run-buildbot:206
 ;;
+check-format-clang)
+    ! grep -rnI '[[:blank:]]$' clang/lib clang/include clang/docs
----------------
We shouldn't be adding a clang-specific job to this file, since this is for libc++ jobs. Please either find the right way to escape the command in the buildkite-pipeline file or create a script like `run-buildbot` within Clang, and then move that job there. The latter might make more sense if we want to move more and more stuff to this way of doing CI in the future, but we'll need the Clang folks to be on board.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153920/new/

https://reviews.llvm.org/D153920



More information about the libcxx-commits mailing list