[libcxx-commits] [PATCH] D154246: [libc++] Add check for building with picolibc

Mon Jul 3 00:56:59 PDT 2023

DavidSpickett added inline comments.

================
Comment at: libcxx/utils/ci/run-buildbot:608
+    clean
+    ${MONOREPO_ROOT}/libcxx/utils/ci/build-picolibc.sh \
+        --build-dir "${BUILD_DIR}" \
----------------
DavidSpickett wrote:
> Mordante wrote:
> > Why do we need to build picolib every CI run instead of storing it in the base image?
> > If that is really needed we should add some documentation why it's needed.
> Assuming we can find a way to use this script directly in Linaro's container builds, it's not a problem. That ensures anyone can reproduce it easily.
> 
> The justification for picking a fixed version should be documented somewhere even if it's just that it's whatever the current version was at the time.
The other problem doing this is how do we place the library in a place that would also be appropriate for anyone reproducing this without the container itself. I guess people could set an env var for the linker, but it's one more difference they have to account for.

Building it each time keeps it isolated, at the cost of compile time each time.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154246/new/

https://reviews.llvm.org/D154246