[libcxx-commits] [PATCH] D153216: [libc++][Modules] Add missing includes to public headers

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D153216#4466307 <https://reviews.llvm.org/D153216#4466307>, @iana wrote:

> In D153216#4466234 <https://reviews.llvm.org/D153216#4466234>, @Mordante wrote:
>
>> In D153216#4461976 <https://reviews.llvm.org/D153216#4461976>, @iana wrote:
>>
>>> @Mordante @ldionne do either of you understand the CI failure? I can't make heads or tails of it...
>>
>> Do you have a link to this failed build? The latest failure is just a `#include <__memory/uninitialized_buffer.h>`, I assume you don't need help with that.
>
> It’s this one https://buildkite.com/llvm-project/libcxx-ci/builds/27284#018908b1-cc51-4a8b-af88-8bd36ded537b there’s a c++ module error that I can’t figure out

Thanks! The issue is that you added a new named declaration to `<type_traits>` and didn't export it from the `std` module. When they are no longer in sync this test fails.

However I'm not convinced the added named declaration `is_execution_policy` should be part of `<type_traits>`. Let's see what @philnik has to say.



================
Comment at: libcxx/include/type_traits:473
+#include <__type_traits/is_equality_comparable.h>
+#include <__type_traits/is_execution_policy.h>
 #include <__type_traits/is_final.h>
----------------
@philnik `is_execution_policy` is part of `<execution>`. I don't find the reason why this has been added to the `__type_traits` directory. Is that a bug?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153216/new/

https://reviews.llvm.org/D153216