[libcxx-commits] [PATCH] D142909: [libc++] Addresses LWG3755.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libcxx/test/libcxx/ranges/range.adaptors/range.adaptor.tuple/tuple-for-each.pass.cpp:1
+//===----------------------------------------------------------------------===//
+//
----------------
philnik wrote:
> IMO this should be tested through the public API. Otherwise this could regress easily if we refactor internals.
All the places that currently use `tuple-for-each` return `void` right now. I think that's the only way we have of testing this right now.


================
Comment at: libcxx/test/libcxx/ranges/range.adaptors/range.adaptor.tuple/tuple-for-each.pass.cpp:23
+struct Evil {
+  void operator,(Evil) { abort(); }
+};
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142909/new/

https://reviews.llvm.org/D142909