[libcxx-commits] [PATCH] D133661: [libc++] Improve binary size when using __transaction

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

In D133661#4093298 <https://reviews.llvm.org/D133661#4093298>, @bgraur wrote:

> We're seeing a lot of fallout from this patch and they all look related to the ODR violations that seem to be intentionally added here: both the patch description and the comment for the `__exception_guard` mention explicitly that combinations of code compiled with exceptions and without exceptions are common.
>
> Am I missing something here?

Do you have a specific example? We have similar ODR violations all over the code base related to exception handling.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133661/new/

https://reviews.llvm.org/D133661