[libcxx-commits] [PATCH] D142957: [CMake][runtimes] Redo the --unwindlib=none and -nostdlib++ checks

[Petr Hosek via Phabricator via libcxx-commits]

phosek created this revision.
phosek added reviewers: mstorsjo, smeenai, beanz.
Herald added a project: All.
phosek requested review of this revision.
Herald added projects: libc++, libc++abi.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.
Herald added a reviewer: libc++abi.

Recent CMake change made the unused argument warning more strict:
https://gitlab.kitware.com/cmake/cmake/-/commit/950effe434623b50a1c85e2c53ed592210e79ceb

      

After that change, runtimes build started failing. Upon investigation,
it turned out that our --unwindlib=none and -nostdlib++ checks weren't
correct since the flags wouldn't be correct wrapped in
--{start,end}-no-unused-arguments. Furthermore, the
llvm_check_compiler_linker_flag macro wouldn't correctly propagate the
flag.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D142957

Files:
  cmake/Modules/LLVMCheckCompilerLinkerFlag.cmake
  runtimes/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D142957.493495.patch
Type: text/x-patch
Size: 6047 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230131/30bf4779/attachment.bin>