[libcxx-commits] [PATCH] D142811: [libcxx][ranges] revert join_view::iterator and sentinel to be in-class

[Hui via Phabricator via libcxx-commits]

huixie90 added inline comments.


================
Comment at: libcxx/include/__ranges/join_view.h:184
+  template <class _Tp>
+  struct __is_join_view_iterator_checker{
+    static false_type __check();
----------------
philnik wrote:
> This seems quite complicated. Is there a reason not to use `__is_primary_template` instead?
I think the idea is exactly the same (the sfinae technique is also exactly the same but I did not know it is abstracted in _IsValidExpansion). but __is_primary_template does not sound the right name


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142811/new/

https://reviews.llvm.org/D142811