[libcxx-commits] [PATCH] D138795: [libc++] Don't assume that string_view::const_iterator is a raw pointer

[Louis Dionne via Phabricator via libcxx-commits]

ldionne marked 4 inline comments as done.
ldionne added inline comments.


================
Comment at: libcxx/include/__format/formatter_output.h:282
 template <class _CharT, class _ParserCharT, class _UnaryOperation>
 _LIBCPP_HIDE_FROM_ABI auto __write_transformed(const _CharT* __first, const _CharT* __last,
                                                output_iterator<const _CharT&> auto __out_it,
----------------
I stumbled upon this, but this is never tested with non-`char*` iterators, it seems. Same for a few functions below. It is probably worth investigating to add some test coverage.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138795/new/

https://reviews.llvm.org/D138795