[libcxx-commits] [PATCH] D142526: [libc++][NFC] Rename multidimentional uninitialized algorithms

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/include/__memory/uninitialized_algorithms.h:407
 // If the object being constructed is an array, each element of the array is allocator-constructed,
 // recursively. If an exception is thrown during the construction of an array, the initialized
 // elements are destroyed in reverse order of initialization using allocator destruction.
----------------
philnik wrote:
> Mordante wrote:
> > I'm not entirely sold on the name `multidimensional`, maybe `recursive` would be a better name. WDYT?
> > (I did notice `__allocator_destroy_multidimensional` already exists.)
> I think `multidimensional` makes it more clear that it's about dimensions, not that is calls itself recursively for constructing the types in a single dimension or something similar. I'm open to other ideas though, I mostly copied the name from `__allocator_destroy_multidimensional`.
Also a fair point, I don't have a great name. When we can come up with something better we can change it later.
I still see this as an improvement since the naming is more consistent.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142526/new/

https://reviews.llvm.org/D142526