[libcxx-commits] [PATCH] D142526: [libc++] Rename multidimentional uninitialized algorithms

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jan 25 09:52:37 PST 2023


philnik added inline comments.


================
Comment at: libcxx/include/__memory/uninitialized_algorithms.h:407
 // If the object being constructed is an array, each element of the array is allocator-constructed,
 // recursively. If an exception is thrown during the construction of an array, the initialized
 // elements are destroyed in reverse order of initialization using allocator destruction.
----------------
Mordante wrote:
> I'm not entirely sold on the name `multidimensional`, maybe `recursive` would be a better name. WDYT?
> (I did notice `__allocator_destroy_multidimensional` already exists.)
I think `multidimensional` makes it more clear that it's about dimensions, not that is calls itself recursively for constructing the types in a single dimension or something similar. I'm open to other ideas though, I mostly copied the name from `__allocator_destroy_multidimensional`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142526/new/

https://reviews.llvm.org/D142526



More information about the libcxx-commits mailing list