[libcxx-commits] [PATCH] D142311: [libc++][test] Improves locale validation.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jan 25 09:15:48 PST 2023


Mordante added a comment.

Note this is still a proof-of-concept version not a clean patch.



================
Comment at: libcxx/test/std/containers/container.adaptors/container.adaptors.format/format.functions.tests.h:607
+#  else
+#    error XXX
+#  endif
----------------
Debug to validate the changes work locally.


================
Comment at: libcxx/utils/libcxx/test/dsl.py:524
+      os.makedirs(config.config_site_root)
+    AddCompileFlag(f"-I {config.config_site_root}").applyTo(config)
+
----------------
This is a bit hacky to add the path to the includes. I don't want to pollute the source directory with this file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142311/new/

https://reviews.llvm.org/D142311



More information about the libcxx-commits mailing list