[libcxx-commits] [PATCH] D142520: [libc++][ranges] Temporarily mark `ranges::join_view` as experimental.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM w/ changes and green CI



================
Comment at: libcxx/include/__config:256
 #    define _LIBCPP_HAS_NO_INCOMPLETE_FORMAT
+#    define _LIBCPP_HAS_NO_EXPERIMENTAL_RANGES_JOIN_VIEW
 #  endif
----------------
I would avoid introducing this macro and simply use `_LIBCPP_ENABLE_EXPERIMENTAL` directly from `join_view`.


================
Comment at: libcxx/test/libcxx/experimental/fexperimental-library.compile.pass.cpp:32-35
+
+#ifdef _LIBCPP_HAS_NO_INCOMPLETE_RANGES_JOIN_VIEW
+#   error "-fexperimental-library should enable ranges::join_view"
+#endif
----------------
This can go away.


================
Comment at: libcxx/test/std/ranges/range.adaptors/range.join.view/adaptor.pass.cpp:10
 // UNSUPPORTED: c++03, c++11, c++14, c++17
+// UNSUPPORTED: libcpp-has-no-experimental-ranges-join-view
 
----------------
I would simply use `UNSUPPORTED: !c++experimental`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142520/new/

https://reviews.llvm.org/D142520