[libcxx-commits] [PATCH] D140675: [AIX] Fix libc++ Symbol Visibility on AIX

David Tenty via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jan 24 10:37:59 PST 2023


daltenty added inline comments.


================
Comment at: libcxx/test/libcxx/vendor/ibm/bad_function_call.cpp:1
+#include <functional>
+
----------------
francii wrote:
> Will update to add the missing RUN lines.
Not sure that this needs a run line, but what this probably does need is:

  - A requires line limiting the target to AIX
  - The boilerplate LLVM license file header
  - Let's follow the file name format of the tests here. Seems like test which are designed to compile and execute successfully end in `.pass.cpp`






Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140675/new/

https://reviews.llvm.org/D140675



More information about the libcxx-commits mailing list