[libcxx-commits] [PATCH] D142311: [libc++][test] Improves locale validation.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

I think this makes sense. However, I would avoid adding new compiler flags since we try to keep our command-lines as minimal as possible in the test suite.

Instead, I would suggest creating a general mechanism for generating a `test_config.h` header (which would be the test-suite equivalent of `__config_site`) and defining those macros there. This header would be generated at `lit` configuration time (not at CMake configuration time like the `__config_site` header). This mechanism would be a bit more general and I think it could even be used for other purposes, for example `glibc-old-ru_RU-decimal-point` could probably be removed in favor of a macro, and we'd gain test coverage in `libcxx/test/std/localization/locale.categories/category.monetary/locale.money.put/locale.money.put.members/put_long_double_ru_RU.pass.cpp`.

We don't have a precedent for doing this in our test suite, so we'll have to design a way to do it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142311/new/

https://reviews.llvm.org/D142311