[libcxx-commits] [PATCH] D136765: [ASan][libcxx] Annotating std::vector with all allocators

Tue Jan 24 06:53:43 PST 2023

philnik added a comment.

In D136765#4076621 <https://reviews.llvm.org/D136765#4076621>, @AdvenamTacet wrote:

> I see that the revision is accepted, but based on the inline commit, I updated static_assert.
> Now `TEST_ALIGNOF` is used instead of two cases with `#if`.
>
> I do not have commiter permissions.

LGTM % nit means that it looks good when the remaining comments are addressed, which are usually just small changes where one can't do much wrong. Are the Name and E-Mail in the commit correct?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136765/new/

https://reviews.llvm.org/D136765