[libcxx-commits] [PATCH] D142063: [libc++][ranges] implement `std::ranges::split_view` (targeting llvm 16)

Sun Jan 22 10:03:45 PST 2023

huixie90 marked 2 inline comments as done.
huixie90 added inline comments.

================
Comment at: libcxx/include/__ranges/split_view.h:120
+
+template <forward_range _Range>
+split_view(_Range&&, range_value_t<_Range>) -> split_view<views::all_t<_Range>, single_view<range_value_t<_Range>>>;
----------------
ldionne wrote:
> Can you remove this constraint and see if anything fails? If not, it means we're missing test coverage. In particular, if you have a Pattern that would both work with `all_t` and is also the `range_value_t` of your range, I guess we want to take this deduction guide, not the one above.
The constraint does not seem to be able to disambiguate these two overloads.
https://godbolt.org/z/h6Kcj53qY

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142063/new/

https://reviews.llvm.org/D142063