[libcxx-commits] [PATCH] D140653: [libc++][format] Implements range_formatter

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D140653#4067357 <https://reviews.llvm.org/D140653#4067357>, @mysterymath wrote:

> Hey, it looks like this change (and maybe https://reviews.llvm.org/D141290) is breaking the Fuchsia toolchain builders: https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-arm64/b8791522961721981361/test-results?sortby=&groupby=
>
> It seems likely that we don't have the fr_FR locale generated on our bots, so I wouldn't expect these tests to work. Is there a way to feature flag these off so that the corresponding portions are disabled if the locale is unavailable?

Sorry for the inconvenience. Unfortunately it's not possible to selectively disable that part of the test. For now I've disabled it unconditionally.
https://reviews.llvm.org/rGd819703410c2362cbafb60117dab45b182d8b13d

I will look at a proper solution, but I would like to have that reviewed properly.

It seems currently the fuchsia buildbot has unrelated issues. Can you test whether main works again with my patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140653/new/

https://reviews.llvm.org/D140653