[libcxx-commits] [PATCH] D140913: [libc++] implement P1020R1 P1973R1 make_unique[shared]_for_overwrite

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libcxx/include/__memory/shared_ptr.h:263
 
+#if _LIBCPP_STD_VER >= 20
+struct __default_initialize_tag {};
----------------
This doesn't need to be guarded since it's not public API.


================
Comment at: libcxx/test/std/utilities/smartptr/unique.ptr/unique.ptr.create/make_unique_for_overwrite.verify.cpp:1
+//===----------------------------------------------------------------------===//
+//
----------------
I don't think this is useful anymore since we have the `._default_init` one!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140913/new/

https://reviews.llvm.org/D140913