[libcxx-commits] [PATCH] D142134: [libc++] add FreeBSD atomic wait support

[Ed Maste via Phabricator via libcxx-commits]

emaste added inline comments.


================
Comment at: libcxx/src/atomic.cpp:82
+
+static void __libcpp_platform_wait_on_address(__cxx_atomic_contention_t const volatile* __ptr,
+                                              __cxx_contention_t __val)
----------------
kib wrote:
> philnik wrote:
> > You don't need the underscores in the argument names, since this is dylib code.
> It is just consistent with the rest of the file (in other words, functions were copy/pasted from the Linux block and edited for FreeBSD).
OK, I would rather keep this consistent with the other implementations, similar to the clang-format discussion above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142134/new/

https://reviews.llvm.org/D142134