[libcxx-commits] [PATCH] D142134: [libc++] add FreeBSD atomic wait support

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik accepted this revision.
philnik added a comment.
This revision is now accepted and ready to land.

LGTM % nit.



================
Comment at: libcxx/src/atomic.cpp:29-33
+#elif defined(__FreeBSD__)
+
+#include <sys/types.h>
+#include <sys/umtx.h>
+
----------------
emaste wrote:
> The CI format job complained about the indentation on the changes in this file, but they are consistent with what is in the file now. Should we run clang-format on it first, and then update this to match?
Just leave it as-is for now. Most of the code-base isn't formatted and we don't enforce it currently in any way.


================
Comment at: libcxx/src/atomic.cpp:82
+
+static void __libcpp_platform_wait_on_address(__cxx_atomic_contention_t const volatile* __ptr,
+                                              __cxx_contention_t __val)
----------------
You don't need the underscores in the argument names, since this is dylib code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142134/new/

https://reviews.llvm.org/D142134