[libcxx-commits] [PATCH] D119036: [libc++] Fix modules and benchmarks CI builds when incomplete features are disabled

Thu Jan 19 14:27:33 PST 2023

v.g.vassilev added inline comments.
Herald added a project: All.

================
Comment at: libcxx/include/module.modulemap:10
 module std [system] {
   export std_config
   // FIXME: The standard does not require that each of these submodules
----------------
I believe the issue that is being fixed in https://reviews.llvm.org/D119468 can be fixed by removing `export std_config` as clang seems to only be able to re-export submodules. Moreover, `std_config` is purely textual and there is nothing to export anyways.

We see such issue on our infrastructure and the suggested fix seem to work.

@ldionne, @aprantl, would it make sense to try it instead, as we should probably really treat `__config` and `__config_site` as textual?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119036/new/

https://reviews.llvm.org/D119036