[libcxx-commits] [PATCH] D127678: [libc++] Implement P1413R3 (Deprecate std::aligned_storage and std::aligned_union)

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jan 19 09:08:02 PST 2023


ldionne accepted this revision.
ldionne added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libcxx/include/any:141-143
+  struct _Buffer {
+    alignas(void*) char __buf_[3*sizeof(void*)];
+  };
----------------
I know this is easy to change, but I would stick with the `DEPRECATED_PUSH` here and everywhere else. This is *really* supposed to be a NFC patch. Once we get rid of `aligned_storage` everywhere in our code base, we can do it here as well trivially.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127678/new/

https://reviews.llvm.org/D127678



More information about the libcxx-commits mailing list