[libcxx-commits] [PATCH] D138413: [libc++] Enable segmented iterator optimizations for join_view::iterator

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/test/std/algorithms/alg.modifying.operations/alg.copy/ranges.copy_backward.pass.cpp:126
 
+template <class Iter, class Sent>
+constexpr void test_join_view() {
----------------
ldionne wrote:
> Can you please make sure that we have a test that uses e.g. `std::copy` with a `join_view_iterator` that is *not* a segmented iterator?
Specifically, please mess up the constraint on purpose and see what fails. If nothing fails, we're missing coverage and we need to add it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138413/new/

https://reviews.llvm.org/D138413