[libcxx-commits] [PATCH] D140675: [AIX] Fix libc++ Symbol Visibility on AIX

[David Tenty via Phabricator via libcxx-commits]

daltenty added a comment.

Looking better, still needs a test though.



================
Comment at: libcxx/include/__config:173
+#  if defined(_AIX)
+#    define _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION
+#  endif
----------------
Looking at the structure of this, I'm starting to think we should opt-in to the entire block above (starting with `#  if defined(_LIBCPP_BUILDING_LIBRARY) || _LIBCPP_ABI_VERSION >= 2`), since the rationale described inside this block means we likely have the same problem with both these macros.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140675/new/

https://reviews.llvm.org/D140675