[libcxx-commits] [PATCH] D139900: [libc++][ranges] Mark completed Ranges papers and issues as done, bump version macro

Wed Jan 18 12:28:27 PST 2023

ldionne added inline comments.

================
Comment at: libcxx/docs/ReleaseNotes.rst:52
 - P0339R6 - ``polymorphic_allocator<>`` as a vocabulary type
+- P2325R3 - Views should not be required to be default constructible

----------------
Mordante wrote:
> var-const wrote:
> > philnik wrote:
> > > var-const wrote:
> > > > Should we add any other papers that this patch marks as done (or that were marked as done recently) here? This one is probably worth calling out because it bumps the ranges version macro. I'm not sure if others are worth calling out since they focus on fixing defects rather than adding new features, what do you think?
> > > I think it makes sense to list all papers. That allows people to quickly find out if a paper has been implemented that they are interested in, even if it's not a major change. I'm a lot more on the fence about LWG issues, since that would probably result in a lot of noise.
> > Personally, I would prefer to only list major papers (I don't like having to sift through a bunch of minor papers that are sometimes just outgrowth of LWG issues to find significant new features, if any). I don't feel too strongly about it, though.
> > 
> > @ldionne Louis, do you think it makes more sense to list all implemented papers (even the ones with minor fixes) or only the major ones? I think I'll merge this patch as is but happy to follow up tomorrow with a fuller list if that's what we ultimately decide.
> IMO it depends a bit on how user visible the change is. A small paper that has a lot of user visible impact I would like to see. I think we can even omit large papers, when they have little impact. There are some papers changing mandates clauses in the library, probably not something users are interested in. This one for example https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2020/p2045r1.html, but there are larger papers.
I agree with Mark. Release notes are for things that we want to call out, they are not a laundry list of everything we've done. People have the status pages for that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139900/new/

https://reviews.llvm.org/D139900