[libcxx-commits] [PATCH] D141971: [libc++] Document how to build and run clang-tidy checks

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision as: Mordante.
Mordante added a comment.

Thanks for working on this. LGTM, but I think a native speaker may want to have a pass over the text too.



================
Comment at: libcxx/docs/TestingLibcxx.rst:108-109
+We have libc++-specific clang-tidy checks, which have to be compiled before running
+clang-tidy. Because of that, there are some additional requirements other than just
+having a recent clang-tidy version installed on the system.
+
----------------
I think the other part doesn't add much info.


================
Comment at: libcxx/docs/TestingLibcxx.rst:111
+
+To compile clang-tidy checks, `-DLIBCXX_ENABLE_CLANG_TIDY=On` has to be passed to the
+CMake invocation used to compile libc++. For the CMake invocation and compiling libc++
----------------
Note it seems this gives issues on Debian, the first run works, then trying to run CMake again will try write things in
`/usr/lib/llvm-16/include/c++/v1/__config_site.tmp`, which for good reasons is not allowed.

Have you seen this before? If not I can file a bug report.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141971/new/

https://reviews.llvm.org/D141971