[libcxx-commits] [PATCH] D141947: [NFC][libc++] Remove __unexpected namespace

[Yurong via Phabricator via libcxx-commits]

yronglin marked an inline comment as done.
yronglin added a comment.

Thanks for your review @philnik @huixie90 !



================
Comment at: libcxx/include/__expected/expected.h:84-86
+          !std::__is_std_unexpected<remove_cv_t<_Tp>>::value &&
+          std::__valid_std_unexpected<_Err>::value
       ,
----------------
philnik wrote:
> These aren't ADL lookups. Same for the other changes.
> These aren't ADL lookups. Same for the other changes.




================
Comment at: libcxx/include/__expected/expected.h:84-86
+          !std::__is_std_unexpected<remove_cv_t<_Tp>>::value &&
+          std::__valid_std_unexpected<_Err>::value
       ,
----------------
yronglin wrote:
> philnik wrote:
> > These aren't ADL lookups. Same for the other changes.
> > These aren't ADL lookups. Same for the other changes.
> 
> 
Good catch!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141947/new/

https://reviews.llvm.org/D141947