[libcxx-commits] [PATCH] D141290: [libc++][format] Adds container adaptor formatters.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jan 17 09:20:20 PST 2023


ldionne accepted this revision.
ldionne added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libcxx/include/__format/container_adaptor.h:29-33
+// [container.adaptors.format] only specifies the library should provide the
+// formatter specializations, not which header should provide them.
+// Since <format> includes a lot of headers, add these headers here instead of
+// adding more dependencies like, locale, optinal, string, tuple, etc.  for the
+// adaptor headers. To use the format functions users already include <format>.
----------------
FWIW this rationale makes sense to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141290/new/

https://reviews.llvm.org/D141290



More information about the libcxx-commits mailing list