[libcxx-commits] [PATCH] D141623: [SystemZ][z/OS] Fix cityhash lit for EBCDIC

Zibi Sarbino via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jan 17 07:38:10 PST 2023


zibi marked an inline comment as done.
zibi added inline comments.


================
Comment at: libcxx/test/libcxx/utilities/utility/__murmur2_or_cityhash.pass.cpp:27
+    {/* "CityHash" */ "\x43\x69\x74\x79\x48\x61\x73\x68"},
+    {/* "CitYHash" */ "\x43\x69\x74\x59\x48\x61\x73\x68"},
+};
----------------
philnik wrote:
> I thought more of just making this `{43, 69, 74, 48, 61, 73, 68}`. Or is there a reason not to do that?
Yes, we can do that. I used hex values, otherwise I would need to convert them to decimal values.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141623/new/

https://reviews.llvm.org/D141623



More information about the libcxx-commits mailing list