[libcxx-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

Tue Jan 17 06:11:19 PST 2023

erichkeane added a comment.

In D131858#4054348 <https://reviews.llvm.org/D131858#4054348>, @v.g.vassilev wrote:

> In D131858#4052031 <https://reviews.llvm.org/D131858#4052031>, @erichkeane wrote:
>
>> In D131858#4052026 <https://reviews.llvm.org/D131858#4052026>, @v.g.vassilev wrote:
>>
>>> Thanks a lot @rsmith for providing a fix and thanks a lot @aaron.ballman and @erichkeane for the efforts saving @mizvekov work over the summer. I believe he has sporadic access to internet and soon he will be back to normal. Great example of team work here!!
>>
>> Note we don't yet have the evidence that this is savable yet, we should know in the next day or so.  At minimum, at least 1 of his patches needs to be reverted due to the memory regression.
>
> I see that https://green.lab.llvm.org/green/job/clang-stage2-Rthinlto/6584/ picked up your revert and seems successful. Then the next build is green as well and then starts failing for a reason that’s unrelated to this patch.

Yep!  So only 1 of the patches (D136566 <https://reviews.llvm.org/D136566> needs reverting/further attention).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131858/new/

https://reviews.llvm.org/D131858