[libcxx-commits] [PATCH] D141542: Add FreeBSD XFAILs in preparation for CI runner

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jan 16 09:35:57 PST 2023


philnik accepted this revision.
philnik added a comment.
This revision is now accepted and ready to land.

LGTM if the runner in D128084 <https://reviews.llvm.org/D128084> is happy.



================
Comment at: libcxx/utils/libcxx/test/features.py:267
+  Feature(name='freebsd', when=lambda cfg: '__FreeBSD__' in compilerMacros(cfg)),
+  Feature(name='LIBCXX-FREEBSD-FIXME', when=lambda cfg: '__FreeBSD__' in compilerMacros(cfg))
 ]
----------------
Can we add a trailing comma here? I think python is generally happy with them. If not, ignore this comment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141542/new/

https://reviews.llvm.org/D141542



More information about the libcxx-commits mailing list