[libcxx-commits] [PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

Sat Jan 14 05:19:24 PST 2023

aaron.ballman added a comment.

In D139114#4053022 <https://reviews.llvm.org/D139114#4053022>, @chapuni wrote:

> Excuse me, I have reverted this.
>
> Before landing this, could you please fix new warnings in the current codebase, please?

Thank you for the revert (and good to see you again!).

In D139114#4053166 <https://reviews.llvm.org/D139114#4053166>, @nathanchance wrote:

> For what it’s worth, this triggers a LOT in the Linux kernel for the pattern that @MaskRay pointed out:

Out of curiosity, has it found any true positives that you can tell?

> It would be nice if this was split into a separate flag that could be disabled, as -Wconstant-conversion has not been very noisy up until this point.

We can definitely split it into a separate flag. Alternatively, we could investigate disabling the warning for that code pattern (or moving that bit under its own flag).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139114/new/

https://reviews.llvm.org/D139114