[libcxx-commits] [PATCH] D138413: [libc++] Enable segmented iterator optimizations for join_view::iterator

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/include/__iterator/iterator_with_data.h:78
+
+  constexpr _LIBCPP_HIDE_FROM_ABI iter_reference_t<_Iterator> operator*() { return *__iter_; }
+
----------------
huixie90 wrote:
> this is a bit non-standard. Could you please briefly explain why we have a non-const operator*
I'm not sure. Removed it.


================
Comment at: libcxx/include/__iterator/iterator_with_data.h:80-81
+
+  constexpr _LIBCPP_HIDE_FROM_ABI iter_reference_t<_Iterator> operator*() const { return *__iter_; }
+};
+
----------------
huixie90 wrote:
> questions: do we need `iter_move` and `iter_swap`?
I'm not sure. Added them for completeness.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138413/new/

https://reviews.llvm.org/D138413