[libcxx-commits] [PATCH] D141308: [libc++] Make the libc++ test-suite standalone

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF added a comment.

I'm not convinced this is something that we want to add the complexity for.

There was a lot of work done to remove similar functionality from the test suite in recent years in order to simplify the test harness and make it more maintainable.

Are we sure we want to re-add this?
Is there a way we can add this functionality out-of-band? It seems to me passing LIT the additional configuration lines as part of its invocation should serve your purpose, no? Is there really a need to make this a CMake configurable option if you can just point LIT at the tests?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141308/new/

https://reviews.llvm.org/D141308