[libcxx-commits] [PATCH] D79555: [libc++] [C++20] [P0415] Constexpr for std::complex.

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik closed this revision.
philnik marked 2 inline comments as done.
philnik added a comment.

In D79555#4045429 <https://reviews.llvm.org/D79555#4045429>, @tra wrote:

> CUDA headers need to grow additional magic to make new libc++ code work on the GPU side. It's unfortunate that we need to play catch up here, but short of introducing CUDA support to libc++ itself, there's not much else we can do.

If you're interested in doing that you can post an RFC and tell us what would be required for that.

Closing this, since it doesn't seem to be a libc++ problem.



================
Comment at: libcxx/include/cmath:781
+  }
+#endif // _LIBCPP_STD_VER > 17
+  return __builtin_scalbn(__x, __exp);
----------------
tra wrote:
> Nit: // !__has_constexpr_builtin(__builtin_scalbln)
Thanks! Fixed in 5d9ef6ec3f13e9ca865b25c3e068f2846ff71fa1.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79555/new/

https://reviews.llvm.org/D79555