[libcxx-commits] [PATCH] D140675: [AIX] Fix libc++ Symbol Visibility on AIX

Michael Francis via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jan 11 16:59:55 PST 2023


francii updated this revision to Diff 488430.
francii added a comment.

Do not remove from abi


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140675/new/

https://reviews.llvm.org/D140675

Files:
  libcxx/include/__config


Index: libcxx/include/__config
===================================================================
--- libcxx/include/__config
+++ libcxx/include/__config
@@ -96,7 +96,9 @@
 // Define a key function for `bad_function_call` in the library, to centralize
 // its vtable and typeinfo to libc++ rather than having all other libraries
 // using that class define their own copies.
+# if defined(_AIX) & defined(_LIBCPP_BUILDING_LIBRARY)
 #    define _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION
+# endif
 // Override the default return value of exception::what() for
 // bad_function_call::what() with a string that is specific to
 // bad_function_call (see http://wg21.link/LWG2233). This is an ABI break
@@ -166,8 +168,11 @@
 // Define a key function for `bad_function_call` in the library, to centralize
 // its vtable and typeinfo to libc++ rather than having all other libraries
 // using that class define their own copies.
+#  if defined(_AIX) & defined(_LIBCPP_BUILDING_LIBRARY)
 #    define _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION
 #  endif
+#  endif
+
 
 #  define _LIBCPP_TOSTRING2(x) #x
 #  define _LIBCPP_TOSTRING(x) _LIBCPP_TOSTRING2(x)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D140675.488430.patch
Type: text/x-patch
Size: 1147 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230112/b33fc011/attachment.bin>


More information about the libcxx-commits mailing list