[libcxx-commits] [PATCH] D141294: [libc++] Enable clang-tidy from the buildkite pipeline instead of hard-coding it in run-buildbot

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jan 11 14:23:28 PST 2023


philnik added a comment.

In D141294#4044938 <https://reviews.llvm.org/D141294#4044938>, @ldionne wrote:

> In D141294#4036972 <https://reviews.llvm.org/D141294#4036972>, @philnik wrote:
>
>> The problem is that on some platforms (like Ubuntu) this hard-errors when CMake tries to load the config without the dev package because there are libraries listed which don't actually exist, which means that it's impossible to even build libc++ without them.
>
> Can we add a workaround that tries to detect this case from CMake instead?

The only way I can imagine that working is telling CMake to try to load the file and return when it failes, but I don't think there is a way to do that. I'm not super familiar with CMake though, so I might be wrong.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141294/new/

https://reviews.llvm.org/D141294



More information about the libcxx-commits mailing list