[libcxx-commits] [PATCH] D141453: [libc++][test] cleanup in formatter.h

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

I've been working on a more generic way for test validation, so I probably will change this code in the near future.
But the current version is an improvement, LGTM thanks!

Note the CI errors are unrelated.



================
Comment at: libcxx/test/std/time/time.syn/formatter_tests.h:98
     } catch (const std::format_error& e) {
-#  if defined(_LIBCPP_VERSION)
+      (void)e;
       if constexpr (std::same_as<CharT, char>)
----------------
Nice catch, usually I have tests where I validate `e.what() == expected` which is libc++ specific. This one indeed is generic.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141453/new/

https://reviews.llvm.org/D141453